Implement packed based receive API for UDP packets. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adache concerning memory leaks.
…(in our examples) we can test the functionality of reading a UDP packet until exhaustion.
… buffer before using std::back_inserter. Doing so doubles the memory requirements.
aentinger
added
type: enhancement
facchinm
approved these changes
Oct 15, 2024
|
Ciao @facchinm ☕ 👋 You've self-requested this review faster than I did assign it to you 😉 - will proceed with merge then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the conventions of Arduino's UDP API (outlined in ArduinoCore-API/api/Udp.h) we are offering to our users a packet based API. Reading a packet is started by
parsePacketand finished byflush.